Hi, I saw that it is used indeed only when in multichar (ifdef MULTICHAR_SET). But the fact is that I don't see why. For my own, I think that we need to know the locale encoding even with monobyte encoding. I will show you several examples of completely broken behaviour of mrxvt in its current version (svn as well as released) with ISO8859 encodings! And ISO8859 encodings are really the basic ones.
Anyway I will probably write a mail with all my studies on this code (in fact many mails because there are a lot to say. I have filled a notebook with around 10 pages of notes about the current working of mrxvt and with some potential flaws, and I have much more in my head). But since yesterday I am slightly sick (I have a throat-ache), and I thought it would be cooler this week, but I was wrong. Indeed I was right for one of my activities where I have a one month-pause, but others are still demanding. Anyway I have another activity taking most of my evenings during the week which should do a pause for holidays, so at end of week, which is the sport (I play volley ball and I have probably a match on thursday; plus I am "hiring" a new player which is pretty good, so as the captain, I would like to have her ready for our thursday's match). So wait just a few more days for my propositions (emails are long to write). And be sure I spend most of my nights to explore mrxvt's code (anyway I have no much choice, during the day, I am at work; during the evening I play volleyball; the week-end I go out or play music; I only have my nights to code). See you!! Jehan Gautam Iyer a écrit : > On Tue, Dec 11, 2007 at 11:03:48PM +0100, Jehan wrote: > >> personally I would agree. All my searches let me think that there is few >> chance that we won't find this on most systems. But as I am not an >> expert and knows only the GNU systems (for them I think we will always >> find langinfo.h) and that I saw that this variable HAVE_NL_LANGINFO was >> already in one place (around the include) and also in urxvt, I thought I >> should keep it. >> >> But if you confirm this should be removed, I will then make langinfo.h >> a mandatory include, remove the wrong code and clean everything as a >> consequence. > > I don't think it will be a mandatory include. It should not be needed > unless we're using multichar right? (So some #ifdef HAVE_MULTICHAR or > something)? > > Maybe you can leave it #ifdef'ed for now, and in a few months we can > remove all the outdated stuff completely. > > GI > ------------------------------------------------------------------------- SF.Net email is sponsored by: Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace _______________________________________________ Materm-devel mailing list Materm-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/materm-devel mrxvt home page: http://materm.sourceforge.net
