Hello, personally I would agree. All my searches let me think that there is few chance that we won't find this on most systems. But as I am not an expert and knows only the GNU systems (for them I think we will always find langinfo.h) and that I saw that this variable HAVE_NL_LANGINFO was already in one place (around the include) and also in urxvt, I thought I should keep it.
But if you confirm this should be removed, I will then make langinfo.h a mandatory include, remove the wrong code and clean everything as a consequence. As you wish. But maybe we should get more information about this. Maybe ask to people knowing better the topic? About the commit, I don't know. For my own I received a notification. Jehan Gautam Iyer a écrit : > On Tue, Dec 11, 2007 at 08:39:21PM +0100, Jehan wrote: > >> Of course to be more portable, the better would be to do a >> #ifdef HAVE_NL_LANGINFO >> // code with nl_langinfo (CODESET) >> #else >> // current code >> #endif > > As I've said before, I don't know anything about encodings: But my > suggestion would be NOT to do the above ifdef. > > If the current code is wrong, it should be replaced. The above #ifdef > means maintaining two code branches, one of which is flawed. Plus on my > system, it looks like langinfo.h is provided by glibc. > >> If this is OK for you, I propose to commit this on svn (already modified >> locally on my computer). > > Incidentally, I did not get any commit notification from your latest > commit. Perhaps the SF notify hook is broken. I'll look into it, > > GI > ------------------------------------------------------------------------- SF.Net email is sponsored by: Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://sourceforge.net/services/buy/index.php _______________________________________________ Materm-devel mailing list Materm-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/materm-devel mrxvt home page: http://materm.sourceforge.net
