Ian Romanick wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > Ian Romanick wrote: >> Brian Paul wrote: >>> I'll create mesa_7_0_branch in git right away. That'll be for 7.0 bug >>> fixes only and the trunk will be re-open for new development. >> In the process of adding FBO support, I think I've found some deviations >> from the spec in framebuffer_texture. Some cases when <texture> is zero >> aren't handled correctly. I'll post a patch for review in a few minutes. > > Better late than never, I suppose. Here's the patch. The main problem > with the error checking in framebuffer_texture was that certain > parameters were erroneously checked when <texture> was zero. In that > case, <level>, <textarget>, and <zoffset> are supposed to be ignored. > The <textarget> checking was also a bit over complicated. > > There are some seeming strange bits in the patch (such as converting > "GLint dims" to "char *caller"). Most of these changes are intended to > make the addition of glFramebufferLayerEXT (from EXT_texture_array) easier. > > I'm looking for an ACK or NAK before I commit...
Looks OK. Didn't apply/test it though. -Brian ------------------------------------------------------------------------- This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/ _______________________________________________ Mesa3d-dev mailing list Mesa3d-dev@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mesa3d-dev