----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7048/#review11443 -----------------------------------------------------------
src/files/files.cpp <https://reviews.apache.org/r/7048/#comment24483> why const here and not for fd or offset? src/files/files.cpp <https://reviews.apache.org/r/7048/#comment24484> memory leak? third_party/libprocess/src/tests.cpp <https://reviews.apache.org/r/7048/#comment24485> CHECK(data.size() == 128) ? :) - Vinod Kone On Sept. 12, 2012, 12:23 a.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/7048/ > ----------------------------------------------------------- > > (Updated Sept. 12, 2012, 12:23 a.m.) > > > Review request for mesos and Benjamin Hindman. > > > Description > ------- > > see above > > also: > -removed redundant length field from json > -added missing test for buffered io::read > > > Diffs > ----- > > src/files/files.cpp 806aa35 > src/tests/files_tests.cpp 6ef2004 > src/webui/master/static/jquery.pailer.js edd23d9 > third_party/libprocess/src/tests.cpp 41bf973 > > Diff: https://reviews.apache.org/r/7048/diff/ > > > Testing > ------- > > make check on osx, and redhat > > mesos-local.sh to verify pailer > > > Thanks, > > Ben Mahler > >
