----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7048/#review11491 -----------------------------------------------------------
src/files/files.cpp <https://reviews.apache.org/r/7048/#comment24623> const & src/files/files.cpp <https://reviews.apache.org/r/7048/#comment24625> This isn't complete. It's possible that some number of bytes n which is less than length will get returned and you'll want to keep reading the data until all of length has been read. src/files/files.cpp <https://reviews.apache.org/r/7048/#comment24622> s/nonblock/Failed to make file descriptor non-blocking/ src/files/files.cpp <https://reviews.apache.org/r/7048/#comment24624> s/temp/data/ In the future, we want to use something more akin to unique_ptr. third_party/libprocess/src/process.cpp <https://reviews.apache.org/r/7048/#comment24626> const & third_party/libprocess/src/process.cpp <https://reviews.apache.org/r/7048/#comment24627> const & third_party/libprocess/src/process.cpp <https://reviews.apache.org/r/7048/#comment24628> const & third_party/libprocess/src/process.cpp <https://reviews.apache.org/r/7048/#comment24629> PSA: As much as we are able, let's move towards std::tr1 and C++11 std (rather than Boost). - Benjamin Hindman On Sept. 13, 2012, 2:57 a.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/7048/ > ----------------------------------------------------------- > > (Updated Sept. 13, 2012, 2:57 a.m.) > > > Review request for mesos and Benjamin Hindman. > > > Description > ------- > > see above > > also: > -removed redundant length field from json > -added missing test for buffered io::read > > > Diffs > ----- > > src/files/files.cpp 806aa35 > src/tests/files_tests.cpp 6ef2004 > src/webui/master/static/jquery.pailer.js edd23d9 > third_party/libprocess/src/process.cpp 2d2b56c > third_party/libprocess/src/tests.cpp 41bf973 > > Diff: https://reviews.apache.org/r/7048/diff/ > > > Testing > ------- > > make check on osx, and redhat > > mesos-local.sh to verify pailer > > > Thanks, > > Ben Mahler > >
