----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7295/#review11949 -----------------------------------------------------------
src/detector/detector.cpp <https://reviews.apache.org/r/7295/#comment25481> why do you want run an election if it was not contending? am i reading it wrong, or did you flip the former with latter src/detector/detector.cpp <https://reviews.apache.org/r/7295/#comment25483> do we get multiple of these events as the client library keeps re-trying or only once? src/detector/detector.cpp <https://reviews.apache.org/r/7295/#comment25480> s/a/at src/detector/detector.cpp <https://reviews.apache.org/r/7295/#comment25482> why not do this for non-leading contenders too? src/detector/detector.cpp <https://reviews.apache.org/r/7295/#comment25484> we need timer.isSome() because there is a race between Timer::cancel and we receiving this timedout message? again, why do we need the timeout variable here? is it because, we are expecting multiple timers to be in flight at the same time? - Vinod Kone On Sept. 26, 2012, 6:01 p.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/7295/ > ----------------------------------------------------------- > > (Updated Sept. 26, 2012, 6:01 p.m.) > > > Review request for mesos, John Sirois, Vinod Kone, and Ben Mahler. > > > Description > ------- > > See summary (7 of 7). > > > Diffs > ----- > > src/detector/detector.cpp 0246846 > third_party/libprocess/include/process/delay.hpp cb2fa9a > third_party/libprocess/include/process/timer.hpp 333a806 > third_party/libprocess/src/process.cpp fde7154 > > Diff: https://reviews.apache.org/r/7295/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > >
