> On Sept. 26, 2012, 11:54 p.m., John Sirois wrote: > > src/detector/detector.cpp, line 382 > > <https://reviews.apache.org/r/7295/diff/1/?file=160216#file160216line382> > > > > Any reason not to call expired() instead?
Because that's an "event" from ZooKeeper and I wanted to keep the semantics of that assuming it would only be called in the that case. > On Sept. 26, 2012, 11:54 p.m., John Sirois wrote: > > src/detector/detector.cpp, line 396 > > <https://reviews.apache.org/r/7295/diff/1/?file=160216#file160216line396> > > > > prematurely Thank you. > On Sept. 26, 2012, 11:54 p.m., John Sirois wrote: > > src/detector/detector.cpp, line 439 > > <https://reviews.apache.org/r/7295/diff/1/?file=160216#file160216line439> > > > > expired = true; Well, 'expire = false', but yeah. ;) > On Sept. 26, 2012, 11:54 p.m., John Sirois wrote: > > src/detector/detector.cpp, line 467 > > <https://reviews.apache.org/r/7295/diff/1/?file=160216#file160216line467> > > > > Why not directly expire() here instead of marking state and then > > waiting for connected() before finally expire()ing ? It's possible that there is already a message in our queue to invoke one of the ZooKeeper callbacks (e.g., connected, expired, etc), so we need to delete and recreate another ZooKeeper instance from within those callbacks (to guarantee that the next callbacks we get are associated with the current ZooKeeper instance we have). - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7295/#review11957 ----------------------------------------------------------- On Sept. 26, 2012, 6:01 p.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/7295/ > ----------------------------------------------------------- > > (Updated Sept. 26, 2012, 6:01 p.m.) > > > Review request for mesos, John Sirois, Vinod Kone, and Ben Mahler. > > > Description > ------- > > See summary (7 of 7). > > > Diffs > ----- > > src/detector/detector.cpp 0246846 > third_party/libprocess/include/process/delay.hpp cb2fa9a > third_party/libprocess/include/process/timer.hpp 333a806 > third_party/libprocess/src/process.cpp fde7154 > > Diff: https://reviews.apache.org/r/7295/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > >
