> On Sept. 26, 2012, 9:36 p.m., Vinod Kone wrote: > > src/detector/detector.cpp, line 398 > > <https://reviews.apache.org/r/7295/diff/1/?file=160216#file160216line398> > > > > why do you want run an election if it was not contending? am i reading > > it wrong, or did you flip the former with latter
We were always "running an election" for non-contending instances of the detector. Note that "running an election" == invoking detectMaster. > On Sept. 26, 2012, 9:36 p.m., Vinod Kone wrote: > > src/detector/detector.cpp, line 408 > > <https://reviews.apache.org/r/7295/diff/1/?file=160216#file160216line408> > > > > do we get multiple of these events as the client library keeps > > re-trying or only once? Only one. > On Sept. 26, 2012, 9:36 p.m., Vinod Kone wrote: > > src/detector/detector.cpp, line 466 > > <https://reviews.apache.org/r/7295/diff/1/?file=160216#file160216line466> > > > > we need timer.isSome() because there is a race between Timer::cancel > > and we receiving this timedout message? > > > > again, why do we need the timeout variable here? is it because, we are > > expecting multiple timers to be in flight at the same time? Yes, multiple possible timers. But I decided to pass the session ID instead (see the updated diff). - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7295/#review11949 ----------------------------------------------------------- On Sept. 26, 2012, 6:01 p.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/7295/ > ----------------------------------------------------------- > > (Updated Sept. 26, 2012, 6:01 p.m.) > > > Review request for mesos, John Sirois, Vinod Kone, and Ben Mahler. > > > Description > ------- > > See summary (7 of 7). > > > Diffs > ----- > > src/detector/detector.cpp 0246846 > third_party/libprocess/include/process/delay.hpp cb2fa9a > third_party/libprocess/include/process/timer.hpp 333a806 > third_party/libprocess/src/process.cpp fde7154 > > Diff: https://reviews.apache.org/r/7295/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > >
