> On Sept. 27, 2012, 10:07 p.m., Ben Mahler wrote: > > src/detector/detector.cpp, line 401 > > <https://reviews.apache.org/r/7295/diff/2/?file=160372#file160372line401> > > > > Maybe it's just me but I find structure makes these big paragraph > > comments easier to read: > > > > // Okay, we didn't prematurally expire the session, so either this > > // detector was contending to be a master or not. > > // If it was not, we want to run an election. > > // If it was, either: > > // 1. "We're" still the master (because "we" haven't > > // yet gotten a session expiration). > > // 2. Someone else was the master and they're still the master. > > // 3. Someone else was the master and someone else still is now the > > master. > > // Either way, run an election.
I dramatically simplified the comment. > On Sept. 27, 2012, 10:07 p.m., Ben Mahler wrote: > > src/detector/detector.cpp, line 389 > > <https://reviews.apache.org/r/7295/diff/2/?file=160372#file160372line389> > > > > google-glog comes with CHECK_NOTNULL > > > > you can then one-line it, if you like: > > delete CHECK_NOTNULL(watcher); Great, also fixed a bug in delete ordering, thanks! - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7295/#review12005 ----------------------------------------------------------- On Sept. 27, 2012, 10:02 p.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/7295/ > ----------------------------------------------------------- > > (Updated Sept. 27, 2012, 10:02 p.m.) > > > Review request for mesos, John Sirois, Vinod Kone, and Ben Mahler. > > > Description > ------- > > See summary (7 of 7). > > > Diffs > ----- > > src/detector/detector.cpp 0246846 > > Diff: https://reviews.apache.org/r/7295/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > >
