----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7295/#review12005 -----------------------------------------------------------
src/detector/detector.cpp <https://reviews.apache.org/r/7295/#comment25582> The comment is good, but it's a run-on sentence (had to read it a few times to get it). src/detector/detector.cpp <https://reviews.apache.org/r/7295/#comment25583> google-glog comes with CHECK_NOTNULL you can then one-line it, if you like: delete CHECK_NOTNULL(watcher); src/detector/detector.cpp <https://reviews.apache.org/r/7295/#comment25584> ditto src/detector/detector.cpp <https://reviews.apache.org/r/7295/#comment25585> Maybe it's just me but I find structure makes these big paragraph comments easier to read: // Okay, we didn't prematurally expire the session, so either this // detector was contending to be a master or not. // If it was not, we want to run an election. // If it was, either: // 1. "We're" still the master (because "we" haven't // yet gotten a session expiration). // 2. Someone else was the master and they're still the master. // 3. Someone else was the master and someone else still is now the master. // Either way, run an election. src/detector/detector.cpp <https://reviews.apache.org/r/7295/#comment25586> this comment reads better than the other big ones, so maybe it's just run-ons that I find hard to immediately grok src/detector/detector.cpp <https://reviews.apache.org/r/7295/#comment25587> ditto CHECK_NOTNULL src/detector/detector.cpp <https://reviews.apache.org/r/7295/#comment25588> ditto src/detector/detector.cpp <https://reviews.apache.org/r/7295/#comment25589> ditto third_party/libprocess/include/process/timer.hpp <https://reviews.apache.org/r/7295/#comment25590> curious why we called this thunk? - Ben Mahler On Sept. 27, 2012, 10:02 p.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/7295/ > ----------------------------------------------------------- > > (Updated Sept. 27, 2012, 10:02 p.m.) > > > Review request for mesos, John Sirois, Vinod Kone, and Ben Mahler. > > > Description > ------- > > See summary (7 of 7). > > > Diffs > ----- > > src/detector/detector.cpp 0246846 > > Diff: https://reviews.apache.org/r/7295/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > >
