Hi RJ, Thank you for the answer. I think we are on the same track. Releasing the Sound Source fixes and other fixes one or two month after the 1.12.0 release sound reasonable to me. The only thing we have to care about, that we not fail this target because of currently unfinished changes or changes that requires a longer beta phase.
Kind regards, Daniel 2015-06-03 15:35 GMT+02:00 RJ Ryan <rr...@mixxx.org>: > > On Wed, Jun 3, 2015 at 4:06 AM, Daniel Schürmann <dasch...@mixxx.org> > wrote: > >> Sound Source refactoring release: >> >> >> We are going on circles. >> >> We have argued three month ago that we do not want to delay 1.12 by three >> month because of >> merging the soundsource branch. >> >> Than Owen has proposed, that we can do an another beta after the API is >> stable. RJ has added +1 >> This was also a good solution to me. >> So lets make it happen and let us not delay the important mp3 quality >> fixes by an other year. >> >> > Neither Owen or I said that. Owen said: > > > based on the risks and benefits and our experience with long debugging > > periods after major feature merges, the prudent choice is to keep the > > current soundsource API for the 1.12 release. Once it's out the door, > > then we can immediately look at merging the new API. And as far as I'm > > concerned, as soon as it's stable, we can do another beta right away. > > The "another beta right away" would be 1.13 beta. 1.13 will be a short > cycle with cleanup, bug fixes and no new major features (since I don't see > any that will be ready soon). I'm definitely interested in releasing 1.13 > soon after 1.12.0. There's no reason it has to be a "SS refactor" release > though. It can contain other features and fixes which is why we're going to > keep it in master and cut a 1.13 release branch when other fixes have made > it in. > > Daniel -- I don't have time or energy to continue arguing about this. The > 1.13.0 release will be just like any other and we will try to get it out a > month or two after the 1.12.0 release. That's my decision and I won't > debate it any further. > > thanks, > RJ > > As already discussed, there are actually some important reasons to merge >> is soon: >> >> Mixxx main propose is to play mp3 in time and sample accurate. >> The current master does not fulfill this requirement in any case. >> >> What is the worth of the new shiny sync feature if only the visual >> beatgrid is in sync after a backward seek? >> This most important issue is fixed in: >> https://bugs.launchpad.net/mixxx/+bug/1407394 >> >> I really do not want to read a MIxxx review like that: "Mixxx: nice new >> features but still not usable for auto beat match" >> >> I have grouped all the important fixes under the "soundsource" tag: >> https://bugs.launchpad.net/mixxx/+bugs?field.tag=soundsource >> >> Decoding Quality: >> #1407394 waveform and transport out of sync for mp3 >> <https://bugs.launchpad.net/mixxx/+bug/1407394> >> #580235 Stuttering at start of VBR MP3 playback >> <https://bugs.launchpad.net/mixxx/+bug/580235> >> #1156569 Change Soundsource API to reading float samples >> <https://bugs.launchpad.net/mixxx/+bug/1156569> >> >> Bad file issues: >> #1444478 mp3: files with changing bitrate are playing heavily distorted >> <https://bugs.launchpad.net/mixxx/+bug/1444478> >> #1408100 soundsourcemp3 is clamping >> <https://bugs.launchpad.net/mixxx/+bug/1408100> >> #1446931 MP3 files with varying sample rate are not supported! on >> Win7, NewSoundSourceAPI <https://bugs.launchpad.net/mixxx/+bug/1446931> >> #1448224 MP3: Varying number of channels within a file not supported >> <https://bugs.launchpad.net/mixxx/+bug/1448224> >> #1405832 wrong mp3 track duration and wrong crossfader time >> <https://bugs.launchpad.net/mixxx/+bug/1405832> >> #1450893 some MP3 could not loaded >> <https://bugs.launchpad.net/mixxx/+bug/1450893> >> >> Other: >> <https://bugs.launchpad.net/mixxx/+bug/580235> >> #697902 Strange Asian Characters in File Browser >> <https://bugs.launchpad.net/mixxx/+bug/697902> >> #726222 Flac files in library don't work well >> <https://bugs.launchpad.net/mixxx/+bug/726222> >> <https://bugs.launchpad.net/mixxx/+bug/1408011> >> <https://bugs.launchpad.net/mixxx/+bug/1408100> >> #1418083 Support YYYY-MM-DD + and any other string for year column >> <https://bugs.launchpad.net/mixxx/+bug/1418083> >> >> @Uwe: Please add bugs the, I have missed. >> >> All reasons for a c++11 refactoring or switch to Qt5 are minor compares >> to this. >> So it seams to be reasonable to fix the pending issues of the list above >> plus other important 1,12 fixes, >> without risk regressions by other feature branches or refactoring. >> >> >> > Why would we cut a release branch for 1.13.0 when we haven't even >> released 1.12.0? >> >> Because we do not want to stop merging feature branches to master. >> I if we have a common commitment not to merge features that will delay >> the SS release >> we can continue with the current situation. But than we will loose the >> build server to verify >> the new features. >> >> I have seen the build server is working gain for master. Cant we declare >> the current master build >> as next beta? This way we can announce a beta phase just after releasing >> 1.12.0 >> >> I have also thought about the Version schema. What about just ditching >> the point version >> like Firefox and Chrome? This way we are able to publish a beta at the >> same time we publish a release >> >> Any other ideas? >> >> Kind regards, >> >> Daniel >> >> >> >> >> 2015-06-03 2:16 GMT+02:00 Sean M. Pappalardo - D.J. Pegasus < >> spappala...@mixxx.org>: >> >>> >>> >>> On 06/02/2015 04:13 PM, Sébastien Blaisot wrote: >>> >>>> Secondly, we have some anoying bugs with windows installer that should >>>> be resolved before releasing 1.12 or they will impact next version as >>>> well:\ >>>> >>> >>> I wonder if this is a good time to switch to using WiX to make MSI >>> installers. These handle upgrades gracefully with less effort and offer >>> more automation of which files to remove. Plus we can probably integrate >>> WiX with SCons in such a way that SCons generates it for us as a build >>> target. >>> >>> Sincerely, >>> Sean M. Pappalardo >>> "D.J. Pegasus" >>> Mixxx Developer - Controller Specialist >>> >>> >>> >>> ------------------------------------------------------------------------------ >>> >>> _______________________________________________ >>> Get Mixxx, the #1 Free MP3 DJ Mixing software Today >>> http://mixxx.org >>> >>> >>> Mixxx-devel mailing list >>> Mixxx-devel@lists.sourceforge.net >>> https://lists.sourceforge.net/lists/listinfo/mixxx-devel >>> >> >> >> >> ------------------------------------------------------------------------------ >> >> _______________________________________________ >> Get Mixxx, the #1 Free MP3 DJ Mixing software Today >> http://mixxx.org >> >> >> Mixxx-devel mailing list >> Mixxx-devel@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/mixxx-devel >> > >
------------------------------------------------------------------------------
_______________________________________________ Get Mixxx, the #1 Free MP3 DJ Mixing software Today http://mixxx.org Mixxx-devel mailing list Mixxx-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mixxx-devel
