Simon Montagu wrote: > > I've backed out the formatting changes, but I wouldn't be surprised if > I've introduced others. I think the bidi submission should be limited to bidi changes only (without whitespace/indentation/formatting changes). That makes it easier to review, and the review is what is holding up the check-in at the moment. > nsPresShell.cpp is full of TAB characters, > which makes its whitespacing inherently unstable. Should one report a > bug on something like this? Yes, I think we should have a separate bug for tab problems in source files. Who owns nsPresShell.cpp? Erik
- Re: Review of Bi-Di code, bug 62777 Erik van der Poel
- Re: Review of Bi-Di code, bug 62777 Erik van der Poel
- Re: Review of Bi-Di code, bug 62777 Erik van der Poel
- Re: Review of Bi-Di code, bug 62777 Simon Montagu
- Re: Review of Bi-Di code, bug 62777 Chris Waterson
- Re: Review of Bi-Di code, bug 62777 Simon Montagu
- Re: Review of Bi-Di code, bug 62777 Simon Montagu
- Re: Review of Bi-Di code, bug 62777 Erik van der Poel
- Re: Review of Bi-Di code, bug 62777 Lina Kemmel
- Re: Review of Bi-Di code, bug 62777 Simon Montagu
- Re: Review of Bi-Di code, bug 62777 Erik van der Poel
- Re: Review of Bi-Di code, bug 62777 smontagu
- Re: Review of Bi-Di code, bug 62777 Arthur Barrett
- Re: Review of Bi-Di code, bug 62777 Erik van der Poel
- Re: Review of Bi-Di code, bug 62777 Simon Montagu
- Re: Review of Bi-Di code, bug 62777 Erik van der Poel
- Re: Review of Bi-Di code, bug 62777 Erik van der Poel
- Re: Review of Bi-Di code, bug 62777 Lina Kemmel
- Re: Review of Bi-Di code, bug 62777 Erik van der Poel
- Re: Review of Bi-Di code, bug 62777 Simon Montagu
- Re: Review of Bi-Di code, bug 62777 Erik van der Poel
