Simon Montagu wrote:
>
> [EMAIL PROTECTED] (Erik van der Poel) wrote:
> >
> > What other examples of platform-specific code are there in the XP code?
>
> GetSystem in intl/unicharutil/src/nsBidiUtilsImp.cpp, which can easily
> move into platform directories if that becomes a separate DLL.
This code appears to determine the Windows version (i.e. 95, 98, NT,
etc). What do you use this info for?
> There is also some code in Reflow in
> layout/html/base/src/nsTextFrame.cpp, which I think is connected to
> the same issues (display of Arabic presentation forms) as the passage
> in nsPresShell.cpp.
If this code is converting Unicode character codes to Unicode Arabic
presentation forms, then it probably belongs under mozilla/gfx, where
Unicode character codes are converted to font glyph codes. The gfx
directory also contains platform-specific directories (e.g. windows)
where you could put the platform-specific code. Hopefully this
conversion can be done inside GetWidth and DrawString (and
GetBoundingMetrics) without having to introduce new methods in
nsIRenderingContext.
Erik
