> The "blocked in write" tests in BlockingSocketOps and BlockingChannelOps are 
> problematic as the underlying non-blocking socket may be polled as writable 
> several times before the virtual thread writer blocks indefinitely. The tests 
> were updated recently to additionally test the blocked thread's parkBlocker, 
> which makes it harder to test when it wakes up several times.
> 
> The tests are simplified to avoid special casing the writing case. The 
> runAfterParkedAsync method in both tests now polls the thread until it parks 
> and the parkBlocker is set. BlockingChannelOps tests the expected parkBlocker 
> whereas BlockingSocketOps just tests for a non-null parkBlocker.
> 
> ---------
> - [x] I confirm that I make this contribution in accordance with the [OpenJDK 
> Interim AI Policy](https://openjdk.org/legal/ai).

Alan Bateman has updated the pull request with a new target base due to a merge 
or a rebase. The incremental webrev excludes the unrelated changes brought in 
by the merge/rebase. The pull request contains seven additional commits since 
the last revision:

 - Change runAfterParkedAsync to return Future
 - Merge branch 'master' into JDK-8397221
 - Fixed typos in test comments
 - Remove special casing for write
 - Merge branch 'master' into JDK-8397221
 - Merge branch 'master' into JDK-8397221
 - Initial commit

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/33907/files
  - new: https://git.openjdk.org/jdk/pull/33907/files/7b3a775d..7432c29f

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=33907&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=33907&range=01-02

  Stats: 1343 lines in 19 files changed: 549 ins; 236 del; 558 mod
  Patch: https://git.openjdk.org/jdk/pull/33907.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/33907/head:pull/33907

PR: https://git.openjdk.org/jdk/pull/33907

Reply via email to