On Mon, 16 Nov 2026 10:59:30 GMT, Daniel Fuchs <[email protected]> wrote:
>> Alan Bateman has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fixed typos in test comments > > test/jdk/java/net/vthread/BlockingSocketOps.java line 140: > >> 138: // delayed read from s2 to EOF >> 139: InputStream in = s2.getInputStream(); >> 140: Thread unparker = runAfterParkedAsync(() -> > > Nit: I had the same idea than Volkan that you could use CompletableFuture<?> > here instead of Thread since the only thing you do is calling join(). The > CompletableFuture could be completed at the end of the Thread's Runnable, > either successfully or exceptionally. Okay, we can do that. It does mean changes to a lot of tests but it's all mechanical. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/33907#discussion_r4587161357
