On Mon, 16 Nov 2026 15:58:08 GMT, Alan Bateman <[email protected]> wrote:

>> The "blocked in write" tests in BlockingSocketOps and BlockingChannelOps are 
>> problematic as the underlying non-blocking socket may be polled as writable 
>> several times before the virtual thread writer blocks indefinitely. The 
>> tests were updated recently to additionally test the blocked thread's 
>> parkBlocker, which makes it harder to test when it wakes up several times.
>> 
>> The tests are simplified to avoid special casing the writing case. The 
>> runAfterParkedAsync method in both tests now polls the thread until it parks 
>> and the parkBlocker is set. BlockingChannelOps tests the expected 
>> parkBlocker whereas BlockingSocketOps just tests for a non-null parkBlocker.
>> 
>> ---------
>> - [x] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> Alan Bateman has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Prevent premature close

test/jdk/java/nio/channels/vthread/BlockingChannelOps.java line 943:

> 941:                 future.complete(null);
> 942:             } catch (Throwable ex) {
> 943:                 future.completeExceptionally(ex);

@AlanBateman, you might want to keep the `printStackTrace()` here. Otherwise, 
at the call site, if the test times out and never reaches to `Future::get`, you 
will lose this diagnostics.

Suggestion:

                ex.printStackTrace();
                future.completeExceptionally(ex);

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/33907#discussion_r4590236899

Reply via email to