On Mon, 16 Nov 2026 19:09:40 GMT, Volkan Yazici <[email protected]> wrote:

>> Alan Bateman has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   Prevent premature close
>
> test/jdk/java/nio/channels/vthread/BlockingChannelOps.java line 943:
> 
>> 941:                 future.complete(null);
>> 942:             } catch (Throwable ex) {
>> 943:                 future.completeExceptionally(ex);
> 
> @AlanBateman, you might want to keep the `printStackTrace()` here. Otherwise, 
> at the call site, if the test times out and never reaches to `Future::get`, 
> you will lose this diagnostics.
> 
> Suggestion:
> 
>                 ex.printStackTrace();
>                 future.completeExceptionally(ex);

Okay but if there is a timeout then the failure/timeout handler will take a 
thread dump.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/33907#discussion_r4590268167

Reply via email to