On Mon, 16 Nov 2026 19:37:21 GMT, Alan Bateman <[email protected]> wrote:
>> The "blocked in write" tests in BlockingSocketOps and BlockingChannelOps are >> problematic as the underlying non-blocking socket may be polled as writable >> several times before the virtual thread writer blocks indefinitely. The >> tests were updated recently to additionally test the blocked thread's >> parkBlocker, which makes it harder to test when it wakes up several times. >> >> The tests are simplified to avoid special casing the writing case. The >> runAfterParkedAsync method in both tests now polls the thread until it parks >> and the parkBlocker is set. BlockingChannelOps tests the expected >> parkBlocker whereas BlockingSocketOps just tests for a non-null parkBlocker. >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Alan Bateman has updated the pull request incrementally with one additional > commit since the last revision: > > Print stack trace in unparker thread if it fails Looks good to me. Most of the tests were previously ignoring the returned Thread, which let me think that you might have chosen to ignore the returned CompletableFuture as well to minimize the changes, provided that the stack trace was printed before completing the CF exceptionally. Not ignoring the CF is of course better. ------------- Marked as reviewed by dfuchs (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/33907#pullrequestreview-5926901896
