Hi Robert, > On 20 Dec 2016, at 15:44, Robert Wilton <[email protected]> wrote: > > Hi Giles, > > Thanks for the support, and comments. > > On 19/12/2016 19:37, Giles Heron wrote: >> support >> >> a couple of quick Qs for the authors: >> >> 1) is there a reason why you have the “tags” container in the L3 interface >> but don’t have equivalents in the flexible encapsulation model? since the >> “tags” container is the only thing inside the enclosing “vlan” container I’m >> not sure it’s required. > I agree that these should be consistent, although I'm not sure which one > should be changed. Perhaps adding the tags container to the flexible > encapsulation would be more consistent. I thought that it was always good > practice to put a list into a container?
Yes - in general it’s a good practice to put a list into a container. But in this case the tag list is the only entity in the enclosing vlan container, so I’m not sure you need another level of container. I suppose if you think you may add to the vlan container in future then there may be value in the tags container (so you can get all tags in one operation without getting the rest of the vlan container) >> >> 2) would it be better to rename “push-tags” as “push-tag” to stick with the >> convention of singular names for YANG lists? > Yes. I can also fix that. great. Giles > Thanks, > Rob > >> >> Giles >> >>> On 12 Dec 2016, at 23:31, Lou Berger <[email protected]> wrote: >>> >>> All, >>> >>> This is start of a two week* poll on making >>> draft-wilton-netmod-intf-vlan-yang-04 a NetMod working group >>> document. >>> >>> Please send email to the list indicating "yes/support" or "no/do not >>> support". If indicating no, please state your reservations with the >>> document. If yes, please also feel free to provide comments you'd like >>> to see addressed once the document is a WG document. >>> >>> * Given the holiday, the poll ends December 28. >>> >>> Thank you, >>> NetMod WG Chairs >>> >>> _______________________________________________ >>> netmod mailing list >>> [email protected] >>> https://www.ietf.org/mailman/listinfo/netmod >> _______________________________________________ >> netmod mailing list >> [email protected] >> https://www.ietf.org/mailman/listinfo/netmod > _______________________________________________ netmod mailing list [email protected] https://www.ietf.org/mailman/listinfo/netmod
