Vasumathi Sundaram wrote: > Hi, I would like to request code review comments for the CR "6793859 > ifconfig find_all_global_interfaces() calls dladm_open() for every link" > > The webrev is at: http://cr.opensolaris.org/~vassun08/6793859/ > > It is a very minor change in ifconfig.c; I declared a global variable to > hold the dld_handle, to avoid dladm_open() in ni_entry from being called > for each link during dlpi_walk(). > > I added another fix along with this CR. As part of 6745288, APIs in > libdladm were modified to accept a dladm handle. Some of the modules > that use rcm were changed to use this new prototype. But the error cases > for the returned handle being NULL were not handled properly. In my fix, > I validate the handle value before passing it to the API. Without this, > the dladm APIs could crash when passed an invalid dladm handle. > > > cscope on SWAN is available in my workspace : > /net/zhadum.east/export/ws/vs226613/bugfixes/6793859/usr/src > > I will appreciate your time in this. > > Thanks > Vasumathi > _______________________________________________ > networking-discuss mailing list > [email protected] > I created a new bug report ("6799145: failure of dladm_open not handled in rcm modules") for the second problem and included it in the webrev comments.
Thanks Vasumathi _______________________________________________ networking-discuss mailing list [email protected]
