Peter Memishian wrote: > > Hi, I would like to request code review comments for the CR "6793859 > > ifconfig find_all_global_interfaces() calls dladm_open() for every link" > > > > The webrev is at: http://cr.opensolaris.org/~vassun08/6793859/ > > > > It is a very minor change in ifconfig.c; I declared a global variable to > > hold the dld_handle, to avoid dladm_open() in ni_entry from being called > > for each link during dlpi_walk(). > > For ifconfig.c, please change dld_handle to be stack-local to > find_all_global_interfaces() and passed through dlpi_walk() to ni_entry(). > Don't forget to remove the ARGSUSED about ni_entry(). > Ok. thanks for the suggestion. > For the RCM changes, two broad comments: > > * What is the administrator supposed to think or do when they see > "dld_handle is NULL"? This should be reworded. Also, what is > the rationale for continuing on with a NULL dld_handle rather > than failing the RCM module initialization? (In other words, I > know you were going to investigate this -- so what let you to > this solution?) > > * What is the purpose of repeatedly issuing a warning message > about dld_handle being NULL? > My understanding was that the modules could still proceed without the handle. But I think the better way is to just fail module initialization . In either case, the rcm_daemon has to be restarted to do any useful work. I will update the code to return failure from rcm_mod_init() and remove all the code that validate the dld_handle. > -- > meem >
_______________________________________________ networking-discuss mailing list [email protected]
