Sebastien Roy wrote:
> On Fri, 2009-01-30 at 10:08 -0500, Vasumathi Sundaram wrote:
>   
>> I uploaded a new webrev after fixing the comments at 
>> http://cr.opensolaris.org/~vassun08/6793859-commentsfix .
>>     
>
> Only one comment:
>
> ifconfig.c:
>
> * 1759: This function returns int, not boolean_t, so returning _B_FASE
> (0) is the opposite of what you want.  What's the failure mode for
> ifconfig now that the fix is in place?  Have you tried removing /dev/dld
> and running ifconfig -a plumb to see what happens?
>
> -Seb
>
>
>   
When I did ifconfig -a plumb, it was failing from add_ni() with a dlpi 
error.
find_all_global_interfaces now exits after dladm_open() fails just like 
it does for other error cases.


Thanks
Vasumathi

_______________________________________________
networking-discuss mailing list
[email protected]

Reply via email to