> > > The webrev is at: http://cr.opensolaris.org/~vassun08/6793859/ > > > > * What is the administrator supposed to think or do when they see > > "dld_handle is NULL"? This should be reworded. Also, what is > > the rationale for continuing on with a NULL dld_handle rather > > than failing the RCM module initialization? (In other words, I > > know you were going to investigate this -- so what let you to > > this solution?) > > > > * What is the purpose of repeatedly issuing a warning message > > about dld_handle being NULL? > > > My understanding was that the modules could still proceed without the > handle.
Proceed to what end (what useful work would they do)? > But I think the better way is to just fail module initialization . In > either case, the rcm_daemon has to be restarted to do any useful > work. I will update the code to return failure from rcm_mod_init() and > remove all the code that validate the dld_handle. OK. -- meem _______________________________________________ networking-discuss mailing list [email protected]
