Re: [networking-discuss] Code Review for 6793859

[Vasumathi Sundaram]

Sebastien Roy wrote:
> On Fri, 2009-01-30 at 11:01 -0500, Vasumathi Sundaram wrote:
>   
>> Sebastien Roy wrote:
>>     
>>> ifconfig.c:
>>>
>>> * 1759: This function returns int, not boolean_t, so returning _B_FASE
>>> (0) is the opposite of what you want.  What's the failure mode for
>>> ifconfig now that the fix is in place?  Have you tried removing /dev/dld
>>> and running ifconfig -a plumb to see what happens?
>>>       
>> When I did ifconfig -a plumb, it was failing from add_ni() with a dlpi 
>> error.
>> find_all_global_interfaces now exits after dladm_open() fails just like 
>> it does for other error cases.
>>     
>
> Looking at the updated webrev, while exiting here is fine,
> Perror0_exit() isn't appropriate for a dladm_open() failure.  That exit
> function calls perror(), which uses errno to print something meaningful.
> dladm_open() doesn't set errno, but returns a status code specific to
> libdladm.
>
> -Seb
>
>
>   
Ok. I think I can print an error message to stderr and return instead of 
calling Perror0_exit().
_______________________________________________
networking-discuss mailing list
networking-discuss@opensolaris.org