Again,it looks like something that provide us with no benefit, create a big amount of work and add unrequited abstraction.
On Sat, Mar 14, 2009 at 6:45 AM, Sidar Ok <[email protected]> wrote: > Hi Folks, > > I know this was discussed before : > http://groups.google.com/group/nhibernate-development/browse_thread/thread/cdfddb3b63307dab/661d2b44a2100f9astarted > by Brian Chavez. > > As far as I can see in the trunk and in JIRA, there is no patch provided > and it has been quite a time after the last message. Now I am willing to put > some work in here to provide a patch, if it is OK. > > So here is my proposal step by step, let me know if it makes sense : > > 1 - Extract a new interface, called NHibernate.Logging.ILogger . This > interface will abstract 2 used versions of GetLogger(Type) and > GetLogger(string). > 2 - Put this behind a service locator and change all references to logger > to use this service locator instead, e.g : > ServiceLocator.Get<NHibernate.Logging.ILogger>(typeof(PocoInstantiator)) > 3 - Remove all the assembly dependencies to log4net from the core and move > it to contrib (they might stay in tests though for convenience). > 4 - In contrib, implement a Log4NetLoggerProvider : > NHibernate.Logging.ILogger that simply is a wrapper over the log4net > implementation. > > In contrib we can also provide wrappers for NLog or EL Logging App Block. > So this will be a step forward to have NH to be dependent only .NET FW by > eliminating a hard dependency on log4net. > > Thoughts ? > > -- > Sidar Ok > > http://www.sidarok.com > http://www.twitter.com/sidarok > >
