ravi,
> Hello Alex, > > you use the word “community” and it seems to me that has certain > implications. It is perhaps a sad truth that the word is used in OSS as a > cliche or bromide, that OSS is mostly a *hobby* for very smart people > (men?) otherwise gainfully employed, but I would like to believe that is > not the case. Communities are not built on technicalities, and the concerns > of a community extend beyond the technical. > > Also, this is not about code, is it? It’s documentation. > It is about code. Proposed change was against comments in .c files. And here are a couple of technical reasons to discuss: - amount of commits and git history of these files - finding author of the original comment, git blame - clarity and usefullness of a comment Other reasons are non-technical and should not be considered. Yes, Rick, I do not use underscore. :) I did a couple of pull requests against node, and very well remember, that every single change is an inconvenience. But if it significantly improves something, and this improvement outweights the disadvantages that every single commit poses, it should be merged. Otherwise it should not. It is as simple as that. In that case I prefer to see "they" honestly, because "user" refers to an unlimited number of people. If somebody makes a commit only to change 2 words, it should not be merged. Does it improve clarity? Nope. Dixi. -- -- Job Board: http://jobs.nodejs.org/ Posting guidelines: https://github.com/joyent/node/wiki/Mailing-List-Posting-Guidelines You received this message because you are subscribed to the Google Groups "nodejs" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/nodejs?hl=en?hl=en --- You received this message because you are subscribed to the Google Groups "nodejs" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/groups/opt_out.
