ctubbsii commented on a change in pull request #419:  #408 - Removed 
ClientConfiguration from ClientOpts
URL: https://github.com/apache/accumulo/pull/419#discussion_r180584941
 
 

 ##########
 File path: core/src/main/java/org/apache/accumulo/core/cli/ClientOpts.java
 ##########
 @@ -282,15 +211,24 @@ public void parseArgs(String programName, String[] args, 
Object... others) {
     updateKerberosCredentials(clientConfigFile);
   }
 
+  private  ConnectionInfo cachedInfo = null;
+  private Connector cachedConnector = null;
   protected Instance cachedInstance = null;
-  protected ClientConfiguration cachedClientConfig = null;
+  private Properties cachedProps = null;
 
   synchronized public Instance getInstance() {
-    if (cachedInstance != null)
-      return cachedInstance;
-    if (mock)
-      return cachedInstance = DeprecationUtil.makeMockInstance(instance);
-    return cachedInstance = new 
ZooKeeperInstance(this.getClientConfiguration());
+    if (cachedInstance == null) {
+      if (mock) {
+        cachedInstance = DeprecationUtil.makeMockInstance(instance);
 
 Review comment:
   Mock is deprecated. If we're changing this code anyway, it's probably better 
to go ahead and phase it out, if it isn't going to add too many complications.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to