ctubbsii commented on a change in pull request #419:  #408 - Removed 
ClientConfiguration from ClientOpts
URL: https://github.com/apache/accumulo/pull/419#discussion_r180584057
 
 

 ##########
 File path: core/src/main/java/org/apache/accumulo/core/cli/ClientOpts.java
 ##########
 @@ -252,8 +182,7 @@ public void updateKerberosCredentials() {
    * overwrite the options if the user has provided something specifically.
    */
   public void updateKerberosCredentials(boolean clientSaslEnabled) {
-    if ((saslEnabled || clientSaslEnabled) && null == tokenClassName) {
-      tokenClassName = KerberosToken.CLASS_NAME;
+    if (saslEnabled || clientSaslEnabled) {
 
 Review comment:
   Why remove the `null == tokenClassName` portion? If the code was changed so 
that the tokenClassName is never null... then is this block needed at all 
anymore?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to