ctubbsii commented on a change in pull request #419:  #408 - Removed 
ClientConfiguration from ClientOpts
URL: https://github.com/apache/accumulo/pull/419#discussion_r180582894
 
 

 ##########
 File path: assemble/bin/accumulo-cluster
 ##########
 @@ -244,7 +244,7 @@ function kill_all() {
   done
 
   echo "Cleaning all server entries in ZooKeeper"
-  ${accumulo_cmd} org.apache.accumulo.server.util.ZooZap -master -tservers 
-tracers --site-file "${conf}/accumulo-site.xml"
+  ${accumulo_cmd} org.apache.accumulo.server.util.ZooZap -master -tservers 
-tracers
 
 Review comment:
   Does the `ZooZap` command no longer need access to the site file? I would 
imagine it is one of those utilities that needs the `instance.secret`. I don't 
think a client configuration file will be an adequate substitute.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to