ctubbsii commented on a change in pull request #419: #408 - Removed
ClientConfiguration from ClientOpts
URL: https://github.com/apache/accumulo/pull/419#discussion_r180584037
##########
File path: core/src/main/java/org/apache/accumulo/core/cli/ClientOpts.java
##########
@@ -195,19 +129,15 @@ public AuthenticationToken getToken() {
@Parameter(names = {"-fake", "--mock"}, description = "Use a mock Instance")
public boolean mock = false;
- @Parameter(names = "--site-file",
- description = "Read the given accumulo site file to find the accumulo
instance")
- public String siteFile = null;
-
@Parameter(names = "--ssl", description = "Connect to accumulo over SSL")
public boolean sslEnabled = false;
@Parameter(names = "--sasl", description = "Connecto to Accumulo using SASL
(supports Kerberos)")
public boolean saslEnabled = false;
@Parameter(names = "--config-file", description = "Read the given client
config file. "
- + "If omitted, the path searched can be specified with
$ACCUMULO_CLIENT_CONF_PATH, which "
- + "defaults to
~/.accumulo/config:$ACCUMULO_CONF_DIR/client.conf:/etc/accumulo/client.conf")
+ + "If omitted, the following paths will be searched
~/.accumulo/accumulo-client.properties:"
+ +
"$ACCUMULO_CONF_DIR/accumulo-client.properties:/etc/accumulo/accumulo-client.properties")
Review comment:
I'm not a fan of the file names ending in `.properties`. It's longer to
type, and it exposes implementation detail a bit. I think I prefer the old
`client.conf` file name, or maybe `accumulo-client.conf`. Changing conventions
like this can be a pain for sysadmins... although client configuration was
probably never used much because it wasn't a very mature feature before, so
maybe it's okay to change the convention. Still, I'm not a fan of the
`.properties` extension.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
