ctubbsii commented on a change in pull request #419: #408 - Removed
ClientConfiguration from ClientOpts
URL: https://github.com/apache/accumulo/pull/419#discussion_r180586201
##########
File path:
server/base/src/main/java/org/apache/accumulo/server/cli/ClientOpts.java
##########
@@ -34,6 +32,10 @@ public Instance getInstance() {
if (instance == null) {
return HdfsZooInstance.getInstance();
}
- return new ZooKeeperInstance(this.getClientConfiguration());
+ try {
+ return getConnector().getInstance();
+ } catch (Exception e) {
+ throw new RuntimeException(e);
Review comment:
Same here, with respect to bad exception handling.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
