dlmarion commented on a change in pull request #2305:
URL: https://github.com/apache/accumulo/pull/2305#discussion_r729763497
##########
File path: server/monitor/src/main/java/org/apache/accumulo/monitor/Monitor.java
##########
@@ -287,11 +314,11 @@ public void fetchData() {
for (TabletServerStatus server : mmi.tServerInfo) {
TableInfo summary = TableInfoUtil.summarizeTableStats(server);
- totalIngestRate += summary.ingestRate;
- totalIngestByteRate += summary.ingestByteRate;
- totalQueryRate += summary.queryRate;
- totalScanRate += summary.scanRate;
- totalQueryByteRate += summary.queryByteRate;
+ totalIngest += summary.ingest;
+ totalIngestBytes += summary.ingestBytes;
+ totalQuery += summary.query;
+ totalScan += summary.scan;
+ totalQueryBytes += summary.queryBytes;
Review comment:
Locally I have reverted commit 3455fe6 where I removed the `Rate` class.
This fixes the Monitor issues. I have further changes locally where a single
metric was being used to report two different metrics (incorrectly). At this
point, `Tablet` keeps counts that are reported via Micrometer and it also
calculates rates from the counts that are returned via the Thrift api to the
Monitor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
