EdColeman commented on pull request #2305: URL: https://github.com/apache/accumulo/pull/2305#issuecomment-951400036
From what I've looked at so far, this looks okay. There are some minor check-style issues and one issue with reporting `unknown` metrics I'm still looking, but my one concern so far deals with the reporting op types in Fate metrics. The op_types used to be a map of counters (op_name, metric counter) that were generated dynamically. When an op_type was first seen, a map entry was created and then it would be incremented each time it was seen again. The op types were not predefined, but they are also a finite set. Currently the method that retrieves the map is being flagged as unused and I don't see a replacement, but I need to look deeper to see if it is being handled differently than what I recall. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
