DomGarguilo commented on a change in pull request #2305:
URL: https://github.com/apache/accumulo/pull/2305#discussion_r733921729
##########
File path: test/src/main/resources/log4j2-test.properties
##########
@@ -146,6 +146,30 @@ logger.36.level = error
logger.37.name = org.eclipse.jetty
logger.37.level = warn
+property.metricsFilename = ./target/test-metrics
+
+# appender.metrics.type = Console
+appender.metrics.type = RollingFile
+# appender.metrics.name = LoggingMetricsOutput
Review comment:
```suggestion
```
##########
File path:
core/src/main/java/org/apache/accumulo/core/metrics/MetricsProducer.java
##########
@@ -0,0 +1,611 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.accumulo.core.metrics;
+
+import java.lang.reflect.Field;
+import java.lang.reflect.Modifier;
+import java.util.HashMap;
+import java.util.Map;
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import io.micrometer.core.instrument.MeterRegistry;
+
+/**
+ * Prior to 2.1.0 Accumulo used the <a href=
+ *
"https://hadoop.apache.org/docs/current/api/org/apache/hadoop/metrics2/package-summary.html";>Hadoop
+ * Metrics2</a> framework. In 2.1.0 Accumulo migrated away from the Metrics2
framework to
+ * <a href="https://micrometer.io/";>Micrometer</a>. Micrometer suggests using
a particular
+ * <a href="https://micrometer.io/docs/concepts#_naming_meters";>naming
convention</a> for the
+ * metrics. The table below contains a mapping of the old to new metric names.
+ *
+ * <table border="1">
+ * <caption>Summary of Metric Changes</caption> <!-- fate -->
+ * <tr>
+ * <th>Old Name</th>
+ * <th>Hadoop Metrics2 Type</th>
+ * <th>New Name</th>
+ * <th>Micrometer Type</th>
+ * <th>Notes</th>
+ * </tr>
+ * <tr>
+ * <td>currentFateOps</td>
+ * <td>Gauge</td>
+ * <td>{@link #METRICS_FATE_CURRENT_OPS}</td>
+ * <td>Gauge</td>
+ * <td></td>
+ * </tr>
+ * <tr>
+ * <td>totalFateOps</td>
+ * <td>Gauge</td>
+ * <td>{@link #METRICS_FATE_TOTAL_OPS}</td>
+ * <td>Gauge</td>
+ * <td></td>
+ * </tr>
+ * <tr>
+ * <td>totalZkConnErrors</td>
+ * <td>Gauge</td>
+ * <td>{@link #METRICS_FATE_ERRORS}</td>
+ * <td>Gauge</td>
+ * <td></td>
+ * </tr>
+ * <tr>
+ * <td>FateTxState_NEW</td>
+ * <td>Gauge</td>
+ * <td>{@link #METRICS_FATE_TX}</td>
+ * <td>Gauge</td>
+ * <td>The state is now in a tag: state=new</td>
+ * </tr>
+ * <tr>
+ * <td>FateTxState_IN_PROGRESS</td>
+ * <td>Gauge</td>
+ * <td>{@link #METRICS_FATE_TX}</td>
+ * <td>Gauge</td>
+ * <td>The state is now in a tag: state=in.progress</td>
+ * </tr>
+ * <tr>
+ * <td>FateTxState_FAILED_IN_PROGRESS</td>
+ * <td>Gauge</td>
+ * <td>{@link #METRICS_FATE_TX}</td>
+ * <td>Gauge</td>
+ * <td>The state is now in a tag: state=failed.in.progress</td>
+ * </tr>
+ * <tr>
+ * <td>FateTxState_FAILED</td>
+ * <td>Gauge</td>
+ * <td>{@link #METRICS_FATE_TX}</td>
+ * <td>Gauge</td>
+ * <td>The state is now in a tag: state=failed</td>
+ * </tr>
+ * <tr>
+ * <td>FateTxState_SUCCESSFUL</td>
+ * <td>Gauge</td>
+ * <td>{@link #METRICS_FATE_TX}</td>
+ * <td>Gauge</td>
+ * <td>The state is now in a tag: state=successful</td>
+ * </tr>
+ * <tr>
+ * <td>FateTxState_UNKNOWN</td>
+ * <td>Gauge</td>
+ * <td>{@link #METRICS_FATE_TX}</td>
+ * <td>Gauge</td>
+ * <td>The state is now in a tag: state=unknown</td>
+ * </tr>
+ * <!-- garbage collection -->
+ * <tr>
+ * <td>AccGcStarted</td>
+ * <td>Gauge</td>
+ * <td>{@link #METRICS_GC_STARTED}</td>
+ * <td>Gauge</td>
+ * <td></td>
+ * </tr>
+ * <tr>
+ * <td>AccGcFinished</td>
+ * <td>Gauge</td>
+ * <td>{@link #METRICS_GC_FINISHED}</td>
+ * <td>Gauge</td>
+ * <td></td>
+ * </tr>
+ * <tr>
+ * <td>AccGcCandidates</td>
+ * <td>Gauge</td>
+ * <td>{@link #METRICS_GC_CANDIDATES}</td>
+ * <td>Gauge</td>
+ * <td></td>
+ * </tr>
+ * <tr>
+ * <td>AccGcInUse</td>
+ * <td>Gauge</td>
+ * <td>{@link #METRICS_GC_IN_USE}</td>
+ * <td>Gauge</td>
+ * <td></td>
+ * </tr>
+ * <tr>
+ * <td>AccGcDeleted</td>
+ * <td>Gauge</td>
+ * <td>{@link #METRICS_GC_DELETED}</td>
+ * <td>Gauge</td>
+ * <td></td>
+ * </tr>
+ * <tr>
+ * <td>AccGcErrors</td>
+ * <td>Gauge</td>
+ * <td>{@link #METRICS_GC_ERRORS}</td>
+ * <td>Gauge</td>
+ * <td></td>
+ * </tr>
+ * <tr>
+ * <td>AccGcWalStarted</td>
+ * <td>Gauge</td>
+ * <td>{@link #METRICS_GC_WAL_STARTED}</td>
+ * <td>Gauge</td>
+ * <td></td>
+ * </tr>
+ * <tr>
+ * <td>AccGcWalFinished</td>
+ * <td>Gauge</td>
+ * <td>{@link #METRICS_GC_WAL_FINISHED}</td>
+ * <td>Gauge</td>
+ * <td></td>
+ * </tr>
+ * <tr>
+ * <td>AccGcWalCandidates</td>
+ * <td>Gauge</td>
+ * <td>{@link #METRICS_GC_WAL_CANDIDATES}</td>
+ * <td>Gauge</td>
+ * <td></td>
+ * </tr>
+ * <tr>
+ * <td>AccGcWalInUse</td>
+ * <td>Gauge</td>
+ * <td>{@link #METRICS_GC_WAL_IN_USE}</td>
+ * <td>Gauge</td>
+ * <td></td>
+ * </tr>
+ * <tr>
+ * <td>AccGcWalDeleted</td>
+ * <td>Gauge</td>
+ * <td>{@link #METRICS_GC_WAL_DELETED}</td>
+ * <td>Gauge</td>
+ * <td></td>
+ * </tr>
+ * <tr>
+ * <td>AccGcWalErrors</td>
+ * <td>Gauge</td>
+ * <td>{@link #METRICS_GC_WAL_ERRORS}</td>
+ * <td>Gauge</td>
+ * <td></td>
+ * </tr>
+ * <tr>
+ * <td>AccGcPosOpDuration</td>
+ * <td>Gauge</td>
+ * <td>{@link #METRICS_GC_POST_OP_DURATION}</td>
+ * <td>Gauge</td>
+ * <td></td>
+ * </tr>
+ * <tr>
+ * <td>AccGcRunCycleCount</td>
+ * <td>Gauge</td>
+ * <td>{@link #METRICS_GC_RUN_CYCLE}</td>
+ * <td>Gauge</td>
+ * <td></td>
+ * </tr>
+ * <!-- tablet server -->
+ * <tr>
+ * <td>entries</td>
+ * <td>Gauge</td>
+ * <td>{@link #METRICS_TSERVER_ENTRIES}</td>
+ * <td>Gauge</td>
+ * <td></td>
+ * </tr>
+ * <tr>
+ * <td>entriesInMem</td>
+ * <td>Gauge</td>
+ * <td>{@link #METRICS_TSERVER_MEM_ENTRIES}</td>
+ * <td>Gauge</td>
+ * <td></td>
+ * </tr>
+ * <tr>
+ * <td>activeMajCs</td>
+ * <td>Gauge</td>
+ * <td>{@link #METRICS_TSERVER_MAJC_RUNNING}</td>
+ * <td>Gauge</td>
+ * <td></td>
+ * </tr>
+ * <tr>
+ * <td>queuedMajCs</td>
+ * <td>Gauge</td>
+ * <td>{@link #METRICS_TSERVER_MAJC_QUEUED}</td>
+ * <td>Gauge</td>
+ * <td></td>
+ * </tr>
+ * <tr>
+ * <td>activeMinCs</td>
+ * <td>Gauge</td>
+ * <td>{@link #METRICS_TSERVER_MINC_RUNNING}</td>
+ * <td>Gauge</td>
+ * <td></td>
+ * </tr>
+ * <tr>
+ * <td>queuedMinCs</td>
+ * <td>Gauge</td>
+ * <td>{@link #METRICS_TSERVER_MINC_QUEUED}</td>
+ * <td>Gauge</td>
+ * <td></td>
+ * </tr>
+ * <tr>
+ * <td>totalMinCs</td>
+ * <td>Gauge</td>
+ * <td>{@link #METRICS_TSERVER_MINC_TOTAL}</td>
+ * <td>Gauge</td>
+ * <td></td>
+ * </tr>
+ * <tr>
+ * <td>onlineTablets</td>
+ * <td>Gauge</td>
+ * <td>{@link #METRICS_TSERVER_TABLETS_ONLINE}</td>
+ * <td>Gauge</td>
+ * <td></td>
+ * </tr>
+ * <tr>
+ * <td>openingTablets</td>
+ * <td>Gauge</td>
+ * <td>{@link #METRICS_TSERVER_TABLETS_OPENING}</td>
+ * <td>Gauge</td>
+ * <td></td>
+ * </tr>
+ * <tr>
+ * <td>unopenedTablets</td>
+ * <td>Gauge</td>
+ * <td>{@link #METRICS_TSERVER_TABLETS_UNOPENED}</td>
+ * <td>Gauge</td>
+ * <td></td>
+ * </tr>
+ * <tr>
+ * <td>filesPerTablet</td>
+ * <td>Gauge</td>
+ * <td>{@link #METRICS_TSERVER_TABLETS_FILES}</td>
+ * <td>Gauge</td>
+ * <td></td>
+ * </tr>
+ * <tr>
+ * <td>queries</td>
+ * <td>Gauge</td>
+ * <td>{@link #METRICS_TSERVER_QUERIES}</td>
+ * <td>Gauge</td>
+ * <td></td>
+ * </tr>
+ * <tr>
+ * <td>scannedRate</td>
+ * <td>Gauge</td>
+ * <td>{@link #METRICS_TSERVER_SCANNED_ENTRIES}</td>
+ * <td>Gauge</td>
+ * <td>Prior to 2.1.0 this metric was reported as a rate, it is now the count
and the rate can be
+ * derived</td>
+ * </tr>
+ * <tr>
+ * <td>queryRate</td>
+ * <td>Gauge</td>
+ * <td>{@link #METRICS_TSERVER_SCAN_RESULTS}</td>
+ * <td>Gauge</td>
+ * <td>Prior to 2.1.0 this metric was reported as a rate, it is now the count
and the rate can be
+ * derived</td>
+ * </tr>
+ * <tr>
+ * <td>queryByteRate</td>
+ * <td>Gauge</td>
+ * <td>{@link #METRICS_TSERVER_SCAN_RESULTS_BYTES}</td>
+ * <td>Gauge</td>
+ * <td>Prior to 2.1.0 this metric was reported as a rate, it is now the count
and the rate can be
+ * derived</td>
+ * </tr>
+ * <tr>
+ * <td>ingestRate</td>
+ * <td>Gauge</td>
+ * <td>{@link #METRICS_TSERVER_INGEST_MUTATIONS}</td>
+ * <td>Gauge</td>
+ * <td>Prior to 2.1.0 this metric was reported as a rate, it is now the count
and the rate can be
+ * derived</td>
+ * </tr>
+ * <tr>
+ * <td>ingestByteRate</td>
+ * <td>Gauge</td>
+ * <td>{@link #METRICS_TSERVER_INGEST_BYTES}</td>
+ * <td>Gauge</td>
+ * <td>Prior to 2.1.0 this metric was reported as a rate, it is now the count
and the rate can be
+ * derived</td>
+ * </tr>
+ * <tr>
+ * <td>holdTime</td>
+ * <td>Gauge</td>
+ * <td>{@link #METRICS_TSERVER_HOLD}</td>
+ * <td>Gauge</td>
+ * <td></td>
+ * </tr>
+ * <!-- scans -->
+ * <tr>
+ * <td>scan</td>
+ * <td>Stat</td>
+ * <td>{@link #METRICS_SCAN}</td>
+ * <td>Gauge</td>
+ * <td></td>
+ * </tr>
+ * <tr>
+ * <td>result</td>
+ * <td>Stat</td>
+ * <td>{@link #METRICS_SCAN_RESULTS}</td>
+ * <td>Gauge</td>
+ * <td></td>
+ * </tr>
+ * <tr>
+ * <td>yield</td>
+ * <td>Stat</td>
+ * <td>{@link #METRICS_SCAN_YIELDS}</td>
+ * <td>Gauge</td>
+ * <td></td>
+ * </tr>
+ * <!-- major compactions -->
+ * <tr>
+ * <td>{i|e}_{compactionServiceName}_{executor_name}_queued</td>
+ * <td>Gauge</td>
+ * <td>{@link #METRICS_MAJC_QUEUED}</td>
+ * <td>Gauge</td>
+ * <td>The compaction service information is in a tag:
+ * id={i|e}_{compactionServiceName}_{executor_name}</td>
+ * </tr>
+ * <tr>
+ * <td>{i|e}_{compactionServiceName}_{executor_name}_running</td>
+ * <td>Gauge</td>
+ * <td>{@link #METRICS_MAJC_RUNNING}</td>
+ * <td>Gauge</td>
+ * <td>The compaction service information is in a tag:
+ * id={i|e}_{compactionServiceName}_{executor_name}</td>
+ * </tr>
+ * <!-- minor compactions -->
+ * <tr>
+ * <td>Queue</td>
+ * <td>Stat</td>
+ * <td>{@link #METRICS_MINC_QUEUED}</td>
+ * <td>Timer</td>
+ * <td></td>
+ * </tr>
+ * <tr>
+ * <td>Minc</td>
+ * <td>Stat</td>
+ * <td>{@link #METRICS_MINC_RUNNING}</td>
+ * <td>Timer</td>
+ * <td></td>
+ * </tr>
+ * <!-- replication -->
+ * <tr>
+ * <td>ReplicationQueue</td>
+ * <td>Stat</td>
+ * <td>{@link #METRICS_REPLICATION_QUEUE}</td>
+ * <td>Timer</td>
+ * <td></td>
+ * </tr>
+ * <tr>
+ * <td>ReplicationQueue10m</td>
+ * <td>Quantiles</td>
+ * <td>N/A</td>
+ * <td>N/A</td>
+ * <td></td>
+ * </tr>
+ * <tr>
+ * <td>filesPendingReplication</td>
+ * <td>Stat</td>
+ * <td>{@link #METRICS_REPLICATION_PENDING_FILES}</td>
+ * <td>Gauge</td>
+ * <td></td>
+ * </tr>
+ * <tr>
+ * <td>maxReplicationThreads</td>
+ * <td>Stat</td>
+ * <td>{@link #METRICS_REPLICATION_THREADS}</td>
+ * <td>Gauge</td>
+ * <td></td>
+ * </tr>
+ * <tr>
+ * <td>numPeers</td>
+ * <td>Stat</td>
+ * <td>{@link #METRICS_REPLICATION_PEERS}</td>
+ * <td>Gauge</td>
+ * <td></td>
+ * </tr>
+ * <!-- Updates (ingest) -->
+ * <tr>
+ * <td>permissionErrors</td>
+ * <td>Counter</td>
+ * <td>{@link #METRICS_UPDATE_ERRORS}</td>
+ * <td>Gauge</td>
+ * <td>Type is stored in tag: type=permission</td>
+ * </tr>
+ * <tr>
+ * <td>unknownTabletErrors</td>
+ * <td>Counter</td>
+ * <td>{@link #METRICS_UPDATE_ERRORS}</td>
+ * <td>Gauge</td>
+ * <td>Type is stored in tag: type=unknown.tablet</td>
+ * </tr>
+ * <tr>
+ * <td>constraintViolations</td>
+ * <td>Counter</td>
+ * <td>{@link #METRICS_UPDATE_ERRORS}</td>
+ * <td>Gauge</td>
+ * <td>Type is stored in tag: type=constraint.violation</td>
+ * </tr>
+ * <tr>
+ * <td>commitPrep</td>
+ * <td>Stat</td>
+ * <td>{@link #METRICS_UPDATE_COMMIT_PREP}</td>
+ * <td>Timer</td>
+ * <td></td>
+ * </tr>
+ * <tr>
+ * <td>commitTime</td>
+ * <td>Stat</td>
+ * <td>{@link #METRICS_UPDATE_COMMIT}</td>
+ * <td>Timer</td>
+ * <td></td>
+ * </tr>
+ * <tr>
+ * <td>waLogWriteTime</td>
+ * <td>Stat</td>
+ * <td>{@link #METRICS_UPDATE_WALOG_WRITE}</td>
+ * <td>Timer</td>
+ * <td></td>
+ * </tr>
+ * <tr>
+ * <td>mutationArraysSize</td>
+ * <td>Stat</td>
+ * <td>{@link #METRICS_UPDATE_MUTATION_ARRAY_SIZE}</td>
+ * <td>Distribution Summary</td>
+ * <td></td>
+ * </tr>
+ * <!-- Thrift -->
+ * <tr>
+ * <td>idle</td>
+ * <td>Stat</td>
+ * <td>{@link #METRICS_THRIFT_IDLE}</td>
+ * <td>Distribution Summary</td>
+ * <td></td>
+ * </tr>
+ * <tr>
+ * <td>executie</td>
Review comment:
```suggestion
* <td>execute</td>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
