ctubbsii commented on PR #3355: URL: https://github.com/apache/accumulo/pull/3355#issuecomment-1526799184
I have no idea how to test this change, because I don't even know where I'd start trying to create a bunch of old map files in a recent version of Accumulo and then to try to force a deepCopy in the iterator stack with this reader active. Using the DefaultIteratorEnvironment implementation may be perfectly acceptable in all cases. I'm not sure if there are any pitfalls to be aware of because of the TabletIteratorEnvironment's implementation no longer being used. (And it's not possible to use that without a much bigger refactor that moves this class from the core module to the server module, or by doing a bunch of reflection to try to use the implementation from the server code.) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
