ctubbsii commented on code in PR #3355:
URL: https://github.com/apache/accumulo/pull/3355#discussion_r1180775950
##########
core/src/main/java/org/apache/accumulo/core/iteratorsImpl/system/MapFileIterator.java:
##########
@@ -124,14 +125,15 @@ public Value getTopValue() {
@Override
public SortedKeyValueIterator<Key,Value> deepCopy(IteratorEnvironment env) {
try {
- @SuppressWarnings("deprecation")
- SortedKeyValueIterator<Key,Value> other =
env.reserveMapFileReader(dirName);
- ((InterruptibleIterator) other).setInterruptFlag(interruptFlag);
+ Configuration hadoopConf = new Configuration();
+ FileSystem fs = FileSystem.get(hadoopConf);
Review Comment:
I made that change, and also made some of the fields final that could be. I
noticed that topKey and topValue are never actually assigned... which seems
completely incorrect to me. I opened a discussion in Slack about that, to
discuss before I try to do anything about that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
