keith-turner commented on code in PR #3355:
URL: https://github.com/apache/accumulo/pull/3355#discussion_r1180603488
##########
core/src/main/java/org/apache/accumulo/core/iteratorsImpl/system/MapFileIterator.java:
##########
@@ -124,14 +125,15 @@ public Value getTopValue() {
@Override
public SortedKeyValueIterator<Key,Value> deepCopy(IteratorEnvironment env) {
try {
- @SuppressWarnings("deprecation")
- SortedKeyValueIterator<Key,Value> other =
env.reserveMapFileReader(dirName);
- ((InterruptibleIterator) other).setInterruptFlag(interruptFlag);
+ Configuration hadoopConf = new Configuration();
+ FileSystem fs = FileSystem.get(hadoopConf);
Review Comment:
Should keep teh config and filesystem objects passed into the constructor
instead of creating new ones here.
##########
core/src/main/java/org/apache/accumulo/core/iteratorsImpl/system/MapFileIterator.java:
##########
@@ -124,14 +125,15 @@ public Value getTopValue() {
@Override
public SortedKeyValueIterator<Key,Value> deepCopy(IteratorEnvironment env) {
try {
- @SuppressWarnings("deprecation")
- SortedKeyValueIterator<Key,Value> other =
env.reserveMapFileReader(dirName);
- ((InterruptibleIterator) other).setInterruptFlag(interruptFlag);
+ Configuration hadoopConf = new Configuration();
+ FileSystem fs = FileSystem.get(hadoopConf);
Review Comment:
Should keep the config and filesystem objects passed into the constructor
instead of creating new ones here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
