keith-turner commented on PR #3355: URL: https://github.com/apache/accumulo/pull/3355#issuecomment-1527800231
Looking into a bit more the initial MapFileIterator is at the lowest level s of the stack. For scan and compaction it would have iterators like the ProblemReportingIterator and TimeSettingIterator layered on top of the initial MapFileITerator. If deep copy is called on the stack it will go down through ProblemReportingIterator and TimeSettingIterator, so there is no need to set those up at the lowest level because they are already at higher levels. Since its so low in the stack it should be doing very minimal and I think this changes looks good. Would keep the config passed into the constructor. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
