ctubbsii commented on code in PR #3355:
URL: https://github.com/apache/accumulo/pull/3355#discussion_r1180763997
##########
core/src/main/java/org/apache/accumulo/core/iteratorsImpl/system/MapFileIterator.java:
##########
@@ -124,14 +125,15 @@ public Value getTopValue() {
@Override
public SortedKeyValueIterator<Key,Value> deepCopy(IteratorEnvironment env) {
try {
- @SuppressWarnings("deprecation")
- SortedKeyValueIterator<Key,Value> other =
env.reserveMapFileReader(dirName);
- ((InterruptibleIterator) other).setInterruptFlag(interruptFlag);
+ Configuration hadoopConf = new Configuration();
+ FileSystem fs = FileSystem.get(hadoopConf);
Review Comment:
That makes sense. I must've overlooked those. I thought I had checked for
them, but I guess I got distracted by the fact that it was using the ones from
the environment implementation. I will update that before merging.
Thanks for the thorough review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
