keith-turner commented on code in PR #3417:
URL: https://github.com/apache/accumulo/pull/3417#discussion_r1206792342
##########
server/base/src/main/java/org/apache/accumulo/server/util/ManagerMetadataUtil.java:
##########
@@ -199,10 +199,10 @@ public static void replaceDatafiles(ServerContext
context, KeyExtent extent,
TabletMutator tablet = context.getAmple().mutateTablet(extent);
datafilesToDelete.forEach(tablet::deleteFile);
- scanFiles.forEach(tablet::putScan);
+
scanFiles.stream().map(StoredTabletFile::getTabletFile).forEach(tablet::putScan);
if (path.isPresent()) {
- tablet.putFile(path.orElseThrow(), size);
+ tablet.putFile(path.orElseThrow().getTabletFile(), size);
Review Comment:
As I mentioned in the other comment I think these are existing bugs that
these changes uncovered and these changes will make it easier to write correct
code going forward.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
