[GitHub] [accumulo] dlmarion commented on a diff in pull request #3626: Deprecate InstanceOperations methods that take a String for server

[via GitHub]

dlmarion commented on code in PR #3626:
URL: https://github.com/apache/accumulo/pull/3626#discussion_r1268329776


##########
core/src/main/java/org/apache/accumulo/core/clientImpl/InstanceOperationsImpl.java:
##########
@@ -236,12 +246,61 @@ public List<String> getTabletServers() {
   }
 
   @Override
+  public Set<Server> getServers(ServerType type) {
+    Set<Server> results = new HashSet<>();
+    switch (type) {
+      case COMPACTOR:
+        throw new IllegalArgumentException(
+            "Use ExternalCompactionUtil.getCompactorAddrs instead as it will 
return the compactor grouping");

Review Comment:
   Removed this exception in ea67851. Since I added ResourceGroup to Server, I 
went ahead and implemented this case.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org