dlmarion commented on code in PR #3626:
URL: https://github.com/apache/accumulo/pull/3626#discussion_r1268334413
##########
core/src/main/java/org/apache/accumulo/core/client/admin/InstanceOperations.java:
##########
@@ -172,20 +174,31 @@ Map<String,String>
modifyProperties(Consumer<Map<String,String>> mapMutator)
* @return a list of locations in <code>hostname:port</code> form.
* @since 2.1.0
*/
+ @Deprecated
List<String> getManagerLocations();
/**
* Returns the locations of the active scan servers
*
* @return A set of currently active scan servers.
*/
+ @Deprecated
Set<String> getScanServers();
+ /**
+ * Returns the locations of the active scan servers
+ *
+ * @return A set of currently active scan servers.
+ * @since 3.0.0
+ */
+ Set<Server> getServers(ServerType type);
Review Comment:
I added `resourceGroup` to `Server` in ea67851. This is a little before it's
time, as this is fully implemented in the elasticity branch.
##########
core/src/main/java/org/apache/accumulo/core/client/admin/InstanceOperations.java:
##########
@@ -195,9 +208,20 @@ Map<String,String>
modifyProperties(Consumer<Map<String,String>> mapMutator)
* {@code <ip address>:<port>}
* @return A list of active scans on tablet server.
*/
+ @Deprecated
List<ActiveScan> getActiveScans(String tserver)
throws AccumuloException, AccumuloSecurityException;
+ /**
+ * List the active scans on a tablet server.
+ *
+ * @param server server type and address
+ * @return A list of active scans on tablet server.
+ * @since 3.0.0
+ */
+ List<ActiveScan> getActiveScans(Server server)
Review Comment:
Implemented in ea67851.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
