dlmarion commented on code in PR #3626: URL: https://github.com/apache/accumulo/pull/3626#discussion_r1268337887
########## core/src/main/java/org/apache/accumulo/core/client/admin/servers/ServerType.java: ########## @@ -0,0 +1,23 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * https://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.accumulo.core.client.admin.servers; + +public enum ServerType { + MANAGER, COMPACTOR, SCAN_SERVER, TABLET_SERVER; Review Comment: Note that I did not add `GC` or `MONITOR` here as the client cannot interact with them directly. ########## core/src/main/java/org/apache/accumulo/core/client/admin/InstanceOperations.java: ########## @@ -208,10 +239,26 @@ List<ActiveScan> getActiveScans(String tserver) * {@code <ip address>:<port>} * @return the list of active compactions * @since 1.5.0 + * @deprecated see {@link #getActiveCompactions(Server)} */ + @Deprecated(since = "3.0.0") List<ActiveCompaction> getActiveCompactions(String tserver) throws AccumuloException, AccumuloSecurityException; + /** + * List the active compaction running on a tablet server. Using this method with Review Comment: This needs to be updated. ########## core/src/main/java/org/apache/accumulo/core/summary/Gatherer.java: ########## @@ -158,6 +158,11 @@ private TSummaryRequest getRequest() { return request; } + @SuppressWarnings("deprecation") + private List<String> getTabletServers() { + return ctx.instanceOperations().getTabletServers(); Review Comment: My plan is to use the new methods when the old methods are removed in the merge to the elasticity branch. ########## core/src/main/java/org/apache/accumulo/core/client/admin/InstanceOperations.java: ########## @@ -194,10 +211,24 @@ Map<String,String> modifyProperties(Consumer<Map<String,String>> mapMutator) * @param tserver The tablet server address. This should be of the form * {@code <ip address>:<port>} * @return A list of active scans on tablet server. + * @deprecated see {@link #getActiveScans(Server)} */ + @Deprecated(since = "3.0.0") List<ActiveScan> getActiveScans(String tserver) throws AccumuloException, AccumuloSecurityException; + /** + * List the active scans on a tablet server. Review Comment: This needs to be updated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
