keith-turner commented on code in PR #65:
URL: https://github.com/apache/accumulo-access/pull/65#discussion_r1498130056
##########
src/main/java/org/apache/accumulo/access/Authorizations.java:
##########
@@ -33,13 +36,13 @@
* @since 1.0.0
*/
public final class Authorizations {
- private final Set<String> authorizations;
+ private final SortedSet<String> authorizations;
- private Authorizations(Set<String> authorizations) {
- this.authorizations = Set.copyOf(authorizations);
+ private Authorizations(SortedSet<String> authorizations) {
+ this.authorizations = authorizations;
}
- public Set<String> asSet() {
+ public SortedSet<String> asSet() {
Review Comment:
This returns a mutable object that will change the internal state of the
object when its mutated. The javadoc for this class states its immutable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
