DomGarguilo commented on code in PR #65:
URL: https://github.com/apache/accumulo-access/pull/65#discussion_r1503209065


##########
src/main/java/org/apache/accumulo/access/Authorizations.java:
##########
@@ -58,9 +59,12 @@ public int hashCode() {
     return authorizations.hashCode();
   }
 
+  /**
+   * @return a String containing the sorted, comma-separated set of 
authorizations
+   */
   @Override
   public String toString() {
-    return authorizations.toString();
+    return new TreeSet<>(authorizations).toString();

Review Comment:
   I'm fine with that. Although in that case do you think its worth even 
creating a new method like `toSortedString` or should we just let the user use 
`toSet` and sort and create the string on their own?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to