DomGarguilo commented on code in PR #65:
URL: https://github.com/apache/accumulo-access/pull/65#discussion_r1499606389
##########
src/main/java/org/apache/accumulo/access/Authorizations.java:
##########
@@ -58,9 +59,12 @@ public int hashCode() {
return authorizations.hashCode();
}
+ /**
+ * @return a String containing the sorted, comma-separated set of
authorizations
+ */
@Override
public String toString() {
- return authorizations.toString();
+ return authorizations.stream().sorted().collect(Collectors.joining(","));
Review Comment:
Using a TreeSet will put a space after each comma and add the brackets. e.g.
`[A, B, Y, Z]`
Using the stream with `.joining(",")` will not add the spaces nor the
brackets by default. e.g. `A,B,Y,Z` but the spaces and brackets can be added
obviously.
The TreeSet code would be more simple I think but also would have the
overhead of creating the new TreeSet (which might be negligible in this case).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
