DomGarguilo commented on PR #65: URL: https://github.com/apache/accumulo-access/pull/65#issuecomment-1959791493
> I made some comments on #58 about the general direction of this. IMO we should do the following. > > * Sort in toString for nicer output > * Keep Set instead of SortedSet in the impl and API. Also keep using Set.copyOf. > * Add a unit test to ensure that what asSet() returns is immutable. Try to add something and verify an exception is thrown and the source did not change. Addressed these points in 6aee3e1. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
