keith-turner commented on code in PR #65:
URL: https://github.com/apache/accumulo-access/pull/65#discussion_r1499630328
##########
src/main/java/org/apache/accumulo/access/Authorizations.java:
##########
@@ -58,9 +59,12 @@ public int hashCode() {
return authorizations.hashCode();
}
+ /**
+ * @return a String containing the sorted, comma-separated set of
authorizations
+ */
@Override
public String toString() {
- return authorizations.toString();
+ return authorizations.stream().sorted().collect(Collectors.joining(","));
Review Comment:
Creating a treeset seems fine for this case. Thinking is that when toString
is called its for the purpose of showing a person something, so in that case
the expense is worthwhile. Can optimize later if ever needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
