DomGarguilo opened a new pull request, #4667:
URL: https://github.com/apache/accumulo/pull/4667

   Fixes #4570 
   
   This PR changes the way the duration of a compaction is calculated. The main 
change is the addition of a field, that was added to `FileCompactor`, which 
denotes the age of the current running compaction. This field is ultimately 
propagated to the monitor.
   
   Before these changes, the age of a compaction was calculated by the 
coordinator which took the difference between the timestamps of the first and 
last update it had for that compaction. The bug where the duration was never 
older than the age of the coordinator came from this map of updates it used to 
calculate the compactor age being reinitialized when the coordinator started up.
   
   Details to help with review:
   * `RunningCompactionInfo` is where the diff of timestamps used to be 
calculated and now it just uses the duration value
   * `FileCompactor` now has `currentCompactionStartTime` which is used to 
calculate the age of the current compaction
   * A test case was added to ensure that the age of a duration is greater than 
the age of the compactor
   
   Most other changes are thrift changes or intermediate objects that needed to 
be adjusted to carry this new value.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to