DomGarguilo commented on PR #4667: URL: https://github.com/apache/accumulo/pull/4667#issuecomment-2163843358
One thing I noticed while working on this PR: * `FileCompactor.compactorStartTime` (renamed from `startTime`) is initialized in the constructor so measures the age of the `FileCompactor` object * The new `FileCompactor.currentCompactionStartTime` is set to `System.nanos` in `FileCompactor.call()`. The only usage of `compactorStartTime` is in `CompactionInfo.toThrift()` when it is used to construct an `ActiveCompaction` object where it does `System.currentTimeMillis() - compactor.getStartTime()` to use as the `age` parameter. I haven't looked into it very much yet but it seems like using the new `currentCompactionStartTime` would more accurately represent the age of an active compaction. This would allow us to remove the other variable too. Any thoughts on this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
